Skip to content

lead: add read-only SHADOW command over proposal contract - #764

Closed
n0rpan wants to merge 2 commits into
mainfrom
agent/629-lead-shadow
Closed

n0rpan wants to merge 2 commits into
mainfrom
agent/629-lead-shadow

Conversation

@n0rpan

@n0rpan n0rpan commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

DRAFT: Milestone B SHADOW entry point for #629. T2. #685 remains the first delivery slice; this independent follow-on is reviewable while its #684 dependency and baseline runner test failure clear.

oxa lead --shadow --model MODEL now runs one ordinary print turn with embedded lead instructions and #624's proposal schema. It reads the orchestrator's bounded digest/board/verdict exports and emits proposal JSON. It never applies a proposal or stores a session. Live oxa lead is explicitly unavailable.

The preset exposes only read/grep/find/ls, constructs no hook registries, and bypasses resource discovery. Ambient exec hooks, extensions, MCP, codemode and project instructions cannot expand it. Only model/provider/time/token/offline options are accepted; tool, instruction and extension overrides fail before engine setup. Ordinary session behavior and existing permission/sandbox/engine layers are unchanged. No new orchestration scripts or facts/task-state implementation.

The integration guide includes the exact private directory layout and invocation. Schema success still grants no authority; orchestrator SHADOW comparison is required before supervised use.

Validation at defb740: both new actual-process regressions failed on unchanged main (Unknown option: --shadow) before implementation. Four focused command/schema/documented-recipe tests now pass, including three input reads, an attempted bash call refused without execution, ambient hook suppression and invalid-action/schema repair. Workspace fmt and strict all-target CLI Clippy pass. Full isolated CLI run: 340 PASS, 1 FAIL, 0 ignored. The sole runner crash-recovery failure at work_state.rs:333 (interrupted vs running) also reproduces on untouched main56d2449; reported to runner on #331. No runner test or policy changed. Tests use synthetic data, loopback mocks, cleared environments, isolated HOME/temp and existing sandbox enforcement; no real keys, models or cloud calls.

CI: exact-head own draft gate 43890414577 SUCCESS, including unchanged scans and formatting; CodeQL43890408174 also SUCCESS. Remains draft while the ordered predecessor and baseline runner fixture are unresolved. Per owner steering, Milestone B is outside the v0.2.1 release (#763); this PR requests no review/queue capacity ahead of release-box PRs. Fixture proof is not orchestrator acceptance or an owner evening.

@oxa-agent

oxa-agent Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

O418 handoff: helper is sole writer. Exact headdefb740c6e3526efcc7e008a2d98d0a10fe4a67b; clean worktree, no unpublished edit or main merge by me. Per-module939 flag API question is947comment6947421240; consume the shared published declaration/read API rather than a parallel parser. Preserve existing shadow schema/read-only tool/resource restrictions. O417 forbids forced size splits; O420 permits main merge only for actual conflict/current-head queue rejection. I retain949/carry coordination only.

Resolve the one conflict in oxa/oxa-cli/src/dispatch.rs by keeping both
sides: main's `--goal` load and print/JSON guard, and the #629 shadow
output-schema branch. No main code is dropped.

Also make the read-only `lead --shadow` preset default-off behind the
plain user-only setting `oxa.lead.shadow` (schema, settings page and
lead.md updated), with a regression test for the refusal.
@oxa-agent

oxa-agent Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Follow-up commits by oxa in the goal loop, model openrouter/deepseek-v4.1-flash; outside checks: checks STILL RED: see body; new head 63ecd075.

🤖 Generated with Claude Code (oxa goal loop)

@oxa-agent

oxa-agent Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

O438/O439 mechanical red handoff at63ecd075: lane44082551219 is red on both arches. Read only failed ARM job134036681614 tail: unused_canonical_metadata_does_not_control_routing_or_admission panics in shared mock openai.rs:349 with ReplyWrite/BrokenPipe/TransferEnd. Nightwatch remains the repair writer; no duplicate branch edit, retry waiver or main merge by family coordinator.

@oxa-agent oxa-agent Bot added parked Closed without merging; work kept at tag archive/pr-N, listed in the parked-work index and removed after-0.2.1 Approved work held until v0.2.1 is branched; merges in one batch after labels Nov 17, 2026
@oxa-agent

oxa-agent Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Superseded by the authorized fold into #776: user-only default-off oxa.lead.shadow gate, disabled/project-setting refusal tests and instruction/tool refusal contract are retained in the ordinary-session preset. The #624 proposal schema is byte-identical. Fold controls passed both architectures at53d4446a (lane44141745370); current main-conflict refresh1600bd37 is still qualifying, so this closure is not landing clearance. Archived exact head63ecd0754d260a23a23766e4600698e2b639fcfe as archive/pr-764; label parked; index: #946 (comment). Original branch/source retained. Carry PR: #776; archive: https://github.com/oxstack/ox-llm/tree/archive/pr-764.

@oxa-agent oxa-agent Bot closed this Nov 17, 2026
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/629-lead-shadow branch November 17, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parked Closed without merging; work kept at tag archive/pr-N, listed in the parked-work index

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant